- From: Domenic Denicola <notifications@github.com>
- Date: Thu, 29 Mar 2018 03:29:21 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 29 March 2018 10:30:16 UTC
domenic commented on this pull request. > @@ -1240,13 +1240,13 @@ would look like <pre><code class="lang-javascript"> class ReadableStreamDefaultReader { - constructor(stream) + <a href="#default-reader-constructor">constructor(stream)</a> If we end up doing what @ricea suggested in #907 we'd align more with existing specs so I wouldn't suggest adding anything to Bikeshed for this definition. That said, the domintro blocks (as proposed in #907) are also not very readable in the source either. See e.g. https://github.com/domenic/async-local-storage/blob/master/spec.bs#L239-L249 for my latest attempt. (Explicit `<p>`s needed because of https://github.com/tabatkins/bikeshed/issues/1203.) Personally I'm not too worried about the source readability here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/913#discussion_r178015725
Received on Thursday, 29 March 2018 10:30:16 UTC