- From: Adam Rice <notifications@github.com>
- Date: Thu, 22 Mar 2018 21:58:36 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/streams/pull/910/review/106378599@github.com>
ricea requested changes on this pull request. > @@ -1140,7 +1140,7 @@ nothrow>ReadableStreamAddReadIntoRequest ( <var>stream</var> )</h4> The case where <var>stream</var>.\[[state]] is <code>"closed"</code>, but <var>stream</var>.\[[closeRequested]] is <emu-val>false</emu-val>, will happen if the stream was closed without its controller's close method ever being called: i.e., if the stream was closed by a call to {{ReadableStream/cancel(reason)}}. In this case we allow the - controller's <code>close</code> method to be called and silently do nothing, since the cancelation was outside the + controller's <code>close</code> method to be called and silently do nothing, since the cancellation was outside the I think "cancelation" is wrong too, but WhatWG style says that's how we have to spell it: https://wiki.whatwg.org/wiki/Style > @@ -4258,11 +4258,11 @@ The {{TransformStream()}} constructor accepts as its first argument a JavaScript <dd> <p>A function that is called immediately during creation of the {{TransformStream}}.</p> - <p>Typically this is used enqueue prefix <a>chunks</a>, using + <p>Typically this is used to enqueue prefix <a>chunks</a>, using Good catch, thanks. > {{TransformStreamDefaultController/enqueue()|controller.enqueue()}}. Those chunks will be read from the <a>readable side</a> but don't depend on any writes to the <a>writable side</a>.</p> - <p>If this initial process is asynchronous, for example by virtue of taking some effort to acquire the prefix + <p>If this initial process is asynchronous, for example because it takes some effort to acquire the prefix Good. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/910#pullrequestreview-106378599
Received on Friday, 23 March 2018 04:59:00 UTC