Re: [whatwg/dom] Add AbstractRange and StaticRange (#589)

domenic approved this pull request.

Things seem pretty good, although I wonder if there should be more explaining about how non-live ranges don't really obey the mental model you might expect? E.g. the note at https://whatpr.org/dom/589.html#boundary-points is not accurate for them, and https://whatpr.org/dom/589.html#introduction-to-dom-ranges might want to talk about a static range behaves or something, I dunno.

> @@ -3650,7 +3605,7 @@ be initialized to null.
 
 <h4 id=garbage-collection>Garbage collection</h4>
 
-<a>Nodes</a> have a strong reference to
+<a for=/>nodes</a> have a strong reference to

Should stay uppercase

> @@ -936,8 +936,8 @@ fields above, an <a>event listener</a> is a broader concept.
 which takes an <a>event</a> <var>event</var>, and returns an {{EventTarget}} object. Unless
 specified otherwise it returns null.
 
-<p class="note no-backref"><a>Nodes</a>, <a for=/>shadow roots</a>, and <a>documents</a> override
-the <a>get the parent</a> algorithm.
+<p class="note no-backref"><a for=/>nodes</a>, <a for=/>shadow roots</a>, and <a>documents</a>

Should stay upppercase

>  
- <li>Return <a for=Range>before</a>.
-</ol>
+<p>A <a for=/>node</a> is
+<dfn export for="live range" id=partially-contained>partially contained</dfn> in a <a>live range</a>
+if its an <a for=tree>inclusive ancestor</a> of the <a>live range</a>'s <a for=range>start node</a>

"its" should be "it is" here

> @@ -9844,7 +9711,7 @@ These are the changes made to the features described in
 
 {{Node}} now inherits from {{EventTarget}}.
 
-<a>Nodes</a> are implicitly
+<a for=/>nodes</a> are implicitly

Should still be uppercase

> @@ -8896,29 +8763,29 @@ these steps:
 <ol>
  <li>Let <var>s</var> be the empty string.

This whole algorithm just says "start node" and "end node" a lot but should probably say "the context object's start node"/end node.

(Preexisting problem, though.)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/589#pullrequestreview-104452102