- From: Anne van Kesteren <notifications@github.com>
- Date: Thu, 15 Mar 2018 01:03:32 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fetch/pull/675/review/104102406@github.com>
annevk commented on this pull request.
I can fix these nits if you don't want to, FWIW.
> <!-- Any steps after this must not throw. -->
<li>
- <p>If <var>inputBody</var> is non-null, then run these substeps:
+ <p>If <var>inputBody</var> is non-null and <var>inputBody</var> is <var>body</var>, then run these
+ substeps:
This should be just ", then:"
> @@ -5366,10 +5367,9 @@ constructor must run these steps:
<p class="note no-backref">This makes <var>inputBody</var>'s <a for=body>stream</a>
<a for=ReadableStream>locked</a> and <a for=ReadableStream>disturbed</a> immediately.
- <li><p>If <var>inputBody</var> is <var>body</var>, then set <var>body</var> to a new
- <a for=/>body</a> whose <a for=body>stream</a> is <var>rs</var>, whose <a for=body>source</a>
- is <var>inputBody</var>'s <a for=body>source</a> and whose <a for=body>total bytes</a> is
- <var>inputBody</var>'s <a for=body>total bytes</a>.
+ <li><p>Set <var>body</var> to a new <a for=/>body</a> whose <a for=body>stream</a> is
+ <var>rs</var>, whose <a for=body>source</a> is <var>inputBody</var>'s <a for=body>source</a> and
+ whose <a for=body>total bytes</a> is <var>inputBody</var>'s <a for=body>total bytes</a>.
This needs an Oxford comma. (Also a problem in the original it seems.)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/675#pullrequestreview-104102406
Received on Thursday, 15 March 2018 08:04:26 UTC