Re: [whatwg/fullscreen] Dispatch fullscreenchange on the fullscreen element (#122)

> `fullscreenchange` should dispatch on the element that goes fullscreen and have bubbles and composed set to true. That way it's still compatible with `Document`.

This is now the case, see https://fullscreen.spec.whatwg.org/#run-the-fullscreen-steps which was  done in https://github.com/whatwg/fullscreen/pull/90.

> We should move `onfullscreenchange` to the `GlobalEventHandlers` mixin (using a partial mixin I suppose).

>`fullscreenerror` and `onfullscreenerror` remain as-is, which is a little awkward.

Actually fullscreenerror is also dispatched on the element now. The event handler properties are on both `Element` and `Document`, so moving those to `GlobalEventHandlers` would be fine, which would also make `window.onfullscreenchange` work.

@rniwa @upsuper does that last change sound good to you?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/issues/122#issuecomment-372033846