Re: [whatwg/dom] Change DOMTokenList's replace() to return boolean (#582) from Zirro on 2018-03-08 (public-webapps-github@w3.org from March 2018)

From: Zirro <notifications@github.com>
Date: Thu, 08 Mar 2018 09:03:09 +0000 (UTC)
To: whatwg/dom <dom@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <whatwg/dom/pull/582/c371424284@github.com>

@foolip I've submitted a pull request to the WPT repository now: https://github.com/w3c/web-platform-tests/pull/9920

> Basically it would return true if and only if it actually set the attribute (after the initial canonicalization bit), right?

@bzbarsky I believe this to be the case since the earlier condition - `If context object’s token set does not contain token, then return false` - should rule out any paths where the attribute does not get set. I think this should be covered by the existing tests once they've been updated, but let me know if I've missed something regarding this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/582#issuecomment-371424284

Received on Thursday, 8 March 2018 09:03:43 UTC