- From: Adam Rice <notifications@github.com>
- Date: Thu, 08 Mar 2018 05:50:15 +0000 (UTC)
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 8 March 2018 05:50:39 UTC
I agree we should change it. We already let `writer.abort()` not call underlying sink `abort()` if the stream is closed, so we're not providing a guarantee there. The benefit of the current behaviour is that it lets you know if you accidentally called `abort()` twice, but that doesn't actually seem like such a serious bug: surplus calls to `abort()` are harmless anyway. Compared to that, the cost of having to stick in useless catch statements seems a lot more serious. If there's some benefit to `abort()` throwing that I've forgotten it might change my mind, but at the moment the decision seems pretty clear-cut. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/issues/900#issuecomment-371386874
Received on Thursday, 8 March 2018 05:50:39 UTC