Re: [whatwg/dom] Change DOMTokenList's replace() to return boolean (#582)

Thanks for the feedback. I've restored "then".

> This makes it return true when you replace an existing item with the same item.

I did consider this, but couldn't see a compelling scenario where another behaviour would be preferable. I'd like to hear in case someone does, though.

---

Should I create a pull request in the WPT repository for the updated tests at this stage, or wait for further feedback / implementer interest?

I'd also be interested in submitting patches for this change to the major browser engines (assuming I can get them to compile), though I'll wait until this has been merged into the spec first.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/582#issuecomment-371253795

Received on Wednesday, 7 March 2018 19:23:15 UTC