Re: [w3c/IndexedDB] Add IDBTransaction commit() method (#242)

asutherland commented on this pull request.



> @@ -3142,7 +3150,7 @@ must run these steps:
 1. If |store| has been deleted, [=throw=] an
     "{{InvalidStateError}}" {{DOMException}}.
 
-1. If |transaction| is not [=transaction/active=], [=throw=] a
+4. If |transaction| is not [=transaction/active=], [=throw=] a

The 1 changed to a 4 for some reason here but the "transaction/active" => "transaction/state" transform didn't happen.  (There are other cases where the pre-patch phrasing continues to exist with the state reference implicit, but in algorithms you seem to have consistently changed transaction/active to be explicitly referenced in terms of transaction/state.)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/IndexedDB/pull/242#pullrequestreview-132453523

Received on Wednesday, 27 June 2018 15:22:16 UTC