- From: L. David Baron <notifications@github.com>
- Date: Mon, 25 Jun 2018 18:07:44 -0700
- To: w3ctag/design-reviews <design-reviews@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3ctag/design-reviews/issues/221/400143812@github.com>
I took a look at the [new version of Web Share Target](https://ewilligers.github.io/web-share-target/) and it seems to be what I was expecting after our previous discussion. There are a few areas that could perhaps be better defined, such as: * It would probably be useful to say what a share consists of. I understand it to be a sort of arbitrary bundle of title, text, url, and files. Right now that's [stated in the example section](https://ewilligers.github.io/web-share-target/#usage-example) but the [relevant normative part of the spec](https://ewilligers.github.io/web-share-target/#sharetarget-and-its-members) seems to assume the reader knows what "the title", "the text", etc., are. * The [definitions of the app manifest structure](https://ewilligers.github.io/web-share-target/#sharetarget-and-its-members) contain a bunch of normative "MUST" requirements that seem to be normative requirements on *developers*. Some (many?) in the web standards community consider such requirements to be bad form, although I tend to think there's a time when they're appropriate. However, whether or not they're appropriate here, there should be prose that normatively says what implementations do when these requirements don't hold. (Also see [Hixie's 2006 blog post](https://ln.hixie.ch/?start=1140242962&count=1).) I also took a brief look at the [associated version of Web Share](https://ewilligers.github.io/web-share/), which I don't think I'd looked at before. A few questions came to mind: * I was curious why the `canShare` function exists given that what it does seems to be rather trivial -- or if it's intended to be extended to something more interesting in the future, whether it should return a `Promise`. * I'm a little curious about the use of `FileList` given that the type's definition says that it's "at risk". Does that statement of being "at risk" need to be revisited? Also, looking at issues that cross both specs: * I wonder if there should be some way for associating MIME types with the files. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3ctag/design-reviews/issues/221#issuecomment-400143812
Received on Tuesday, 26 June 2018 01:08:10 UTC