Re: [whatwg/fetch] Specify identity encoding for range requests. Fixes #747. (#751)

annevk commented on this pull request.

Historically WHATWG standards have included non-normative external links when they add a lot of background information, so this seems fine.

I think for certain canvas algorithms we might still normatively refer to books, even, which feels much worse and not a precedent I'd be happy with following.

> @@ -3651,6 +3651,16 @@ Range Requests</cite>. [[HTTP-RANGE]] However, this is not widely supported by b
      <!-- Technically this only applies to HTTP/1.1 and up -->
     </ol>
 
+   <li>
+    <p>If <var>httpRequest</var>'s <a for=request>header list</a> <a for="header list">contains</a>
+    `<code>Range</code>`, then <a for="header list">append</a>
+    `<code>Accept-Encoding</code>`/`<code>identity</code>` to <var>httpRequest</var>'s
+    <a for=request>header list</a>.
+
+    <p class="note no-backref">
+    <a href="https://jakearchibald.github.io/accept-encoding-range-test/">Many servers</a>

You cannot have a newline before `<a` here. We only allow whitespace at the end of paragraphs.

> @@ -3661,7 +3671,7 @@ Range Requests</cite>. [[HTTP-RANGE]] However, this is not widely supported by b
     `<code>Connection</code>`,
     `<code>DNT</code>`, and
     `<code>Host</code>`,
-    are to be <a for="header list">appended</a> if necessary.
+    are to be <a for="header list">appended</a> if necessary, unless already specified.

This should be part of the normative requirement, no?

> Modify httpRequest's header list per HTTP, except for headers already appended prior to this step.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/751#pullrequestreview-125464689

Received on Monday, 4 June 2018 07:51:57 UTC