Re: [w3c/FileAPI] Change label to encoding for FileReader.readAsText (#106)

blixt commented on this pull request.



> @@ -1136,11 +1136,11 @@ the user agent must run the steps below.
 The {{FileReader/readAsText()}} method</h5>
 
 The {{FileReader/readAsText()}} method can be called with an optional parameter,
-<dfn argument for="FileReader/readAsText(blob, label), FileReader/readAsText(), FileReaderSync/readAsText(blob, label)" id="dfn-label">label</dfn>,
+<dfn argument for="FileReader/readAsText(blob, encoding), FileReader/readAsText(), FileReaderSync/readAsText(blob, encoding)" id="dfn-encoding">encoding</dfn>,

I can add the legacy reference too. Is there a precedent for keeping legacy links that I can follow in terms of documenting the reasoning, or possibly a Bikeshed tooling support for adding the legacy reference?

If not, I propose to add this line below:

```html
<a id="dfn-label"><!-- Legacy anchor for when argument name was "label" --></a>
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/FileAPI/pull/106#discussion_r205038384

Received on Wednesday, 25 July 2018 09:20:35 UTC