Re: [whatwg/dom] Don't store is value when it won't be useful (#661)

annevk commented on this pull request.



> @@ -6052,6 +6052,15 @@ given a <var>document</var>, <var>localName</var>, <var>namespace</var>, and opt
    <li><p>Let <var>interface</var> be the <a>element interface</a> for <var>localName</var> and
    <var>namespace</var>.
 
+   <li>
+    <p>If <var>localName</var> is a <a>valid custom element name</a>, or <var>is</var> is not a
+    <a>valid custom element name</a>, then set <var>is</var> to null.</p>
+
+    <p class="note">In this case, even though <var>is</var> was supplied, there's no way that this
+    element will ever be <a lt="upgrade an element">upgraded</a>, so we shouldn't store the

there's -> there is

shouldn't -> will not

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/661#pullrequestreview-139244707

Received on Saturday, 21 July 2018 02:06:52 UTC