- From: Ian Clelland <notifications@github.com>
- Date: Wed, 11 Jul 2018 07:09:45 -0700
- To: whatwg/fullscreen <fullscreen@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fullscreen/pull/107/c404183342@github.com>
Yes, fullscreen is pretty well tested, being one of the first features that Chrome shipped with -- these tests all check the behaviour of `fullscreen *` in policies: * [feature-policy-frame-policy-allowed-for-all.https.sub.html](https://wpt.fyi/results/feature-policy/feature-policy-frame-policy-allowed-for-all.https.sub.html) * [feature-policy-header-policy-allowed-for-all.https.sub.html](https://wpt.fyi/results/feature-policy/feature-policy-header-policy-allowed-for-all.https.sub.html) * [feature-policy-nested-header-policy-allowed-for-all.https.sub.html](https://wpt.fyi/results/feature-policy/feature-policy-nested-header-policy-allowed-for-all.https.sub.html) * [feature-policy-nested-header-policy-allowed-for-self.https.sub.html](https://wpt.fyi/results/feature-policy/feature-policy-nested-header-policy-allowed-for-self.https.sub.html) They do all rely on the [`document.policy`](https://drafts.featurepolicy.rocks/add-introspection/#introspection) object which isn't shipped yet, though, so it may be worthwhile to add a couple of extra tests for that specifically. (In general, I'd like to get to a point where we can test the feature policy mechanism itself separately from its integration with each feature -- with the goal being that if you can test that the feature works correctly when enabled and when disabled, then the wpt/feature-policy tests will ensure that all of the different possible combinations of frames and policies work to get the right {enabled,disabled} state down to the frame. For now, though, I don't mind adding tests for specific combinations of policy-structure+feature to increase test coverage.) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/fullscreen/pull/107#issuecomment-404183342
Received on Wednesday, 11 July 2018 14:10:13 UTC