- From: Adam Rice <notifications@github.com>
- Date: Tue, 10 Jul 2018 23:56:36 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 11 July 2018 06:56:58 UTC
In the implementation of pipeTo(), setting _shuttingDown_ after flushing unwritten reads makes it difficult for implementations to obey the requirement that "Shutdown must stop activity". Generally it means they have to track separately whether they've started to shutdown, making the _shuttingDown_ variable redundant. The exact behaviour while unwritten reads are being flushed may also be ambiguous. Change to set _shuttingDown_ at the beginning of the _Shutdown with an action_ and _Shutdown_ steps. No changes to reference implementation as it already works this way. Fixes #934. You can view, comment on, or merge this pull request online at: https://github.com/whatwg/streams/pull/939 -- Commit Summary -- * Set shuttingDown at the beginning of shutdown -- File Changes -- M index.bs (8) -- Patch Links -- https://github.com/whatwg/streams/pull/939.patch https://github.com/whatwg/streams/pull/939.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/939
Received on Wednesday, 11 July 2018 06:56:58 UTC