- From: Matt Giuca <notifications@github.com>
- Date: Wed, 04 Jul 2018 22:26:18 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/manifest/pull/700/c402609837@github.com>
Note that this change is obsoleted by #701 (but that is a breaking change, whereas this is just editorial). I uploaded this to show what changes we'd need to make if we *don't* go with #701. We should land one or the other. The problem is that the old monkey patch text refers to things that no longer exist in the HTML spec (e.g., the "handle redirects" step). Another problem is that the old text said to run navigate "with exceptions enabled", which doesn't make sense to me, since as far as I can tell the difference between exceptions enabled, and not, is that exceptions enabled = MUST terminate the navigation, whereas no exceptions enabled = MAY open in another top-level browsing context. It seems like the latter is exactly what we want. The first part of the new text is quite formal and I think is a suitable text that could be added to HTML spec to cancel the navigation early if the URL is out of scope. However, the second part is a lot more hand-wavey, because I just couldn't get my head around the whole navigate algorithm in HTML, and figure out a place to insert logic to say "if during navigation, we try to redirect to a URL that is out of scope, cancel the navigation and possibly open it in a new top-level browsing context." So I just added a generic rule. Note that going to #701 is probably actually much simpler, though it requires negotiations since we'd be breaking existing behaviour. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/manifest/pull/700#issuecomment-402609837
Received on Thursday, 5 July 2018 05:26:41 UTC