Re: [w3c/IndexedDB] Add IDBTransaction commit() method (#242)

> > I'd be okay with making abort() throw if the state was _committing_. Thoughts?
> This sounds like the right choice to me.

Done in a40328bbd3999ba8e174e7a4218b790c432e53a6 ... but in a way that may not be web-compatible, at least not without further rework of the PR. Today you can call abort() at any point, even when the transaction is _inactive_, and thus e.g. when the auto-commit has already begun. Since the PR flips the transaction into the new _committing_ state, that would now throw. Requiring abort() to be called only when the transaction is _active_ would have been a better design from the beginning to avoid a race, but it's probably too late for that.

I don't want to introduce yet another state, so we'll see how this goes.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/IndexedDB/pull/242#issuecomment-401899336