Re: [whatwg/streams] In pipeTo spec, the order of checking for shuttingDown disagrees with ref. impl. (#934)

Yes, that makes sense and I really only had some guesswork with the pipeTo tests, the other tests were helpful in finding issues I had forgotten, without the WPT I would have had many subtle bugs, so thank you for making those.

You asked for a list of tests and my comments on them, should I just post that here in a comment or make a new issue or issues for those?

BTW: in order to get back into streams I developed a little further and made a polyfill for streams including a fetch adapter as the Response class is where most ReadableStreams in web apps are originated or end up. This makes it easier for me to experiment with my implementation and report on things I noticed. I'm using MDN's example projects as an example workflow. Maybe it's useful for others as well. See: https://github.com/stardazed/sd-streams-polyfill

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/issues/934#issuecomment-401771970

Received on Monday, 2 July 2018 11:18:02 UTC