- From: Matt Giuca <notifications@github.com>
- Date: Tue, 30 Jan 2018 06:31:06 +0000 (UTC)
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 30 January 2018 06:35:29 UTC
Hi @marcoscaceres, can you have a quick look at this (best to get this small change out the way so it doesn't show up in the diff of my big PR to change unbounded scope). In the case of `start_url` it's just plain wrong (it references a variable "value" that's never defined). But in both cases, I think we do want to call this variable "value" rather than overloading/shadowing the variable name "start URL" or "scope URL", which would otherwise start off being a string and change type to URL part-way through the algorithm. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/manifest/pull/645#issuecomment-361490563
Received on Tuesday, 30 January 2018 06:35:29 UTC