- From: Surma <notifications@github.com>
- Date: Sat, 27 Jan 2018 15:33:02 +0000 (UTC)
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Saturday, 27 January 2018 15:34:04 UTC
surma commented on this pull request. > @@ -385,15 +385,16 @@ like <pre><code class="lang-javascript"> class ReadableStream { - constructor(underlyingSource = {}, { size, highWaterMark } = {}) + <a href="#rs-constructor">constructor</a>(<a href="#rs-constructor">underlyingSource</a> = {}, { size, highWaterMark I realize linking `underlyingSource` to `ReadableStream()` could be seen as questionable. This is just as suggestion. My thinking was that if someone’s looking at the class definition and the constructor, they are most likely a web developer and looking for an interface description. There’s multiple links to `underlyingSource` in the note, so there’s still a path to the definition. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/872#pullrequestreview-92027915
Received on Saturday, 27 January 2018 15:34:04 UTC