Re: [whatwg/streams] Fix pipe not correctly waiting for writes to finish (#884)

Looking at it again, I think we can better align the close and error propagation tests. Right now, we have the following variants for propagating close forward:
1. Closing must be propagated forward: shutdown must not occur until the final write completes
2. Closing must be propagated forward: shutdown must not occur until the final write completes; preventClose = true
3. Closing must be propagated forward: shutdown must not occur until the final write completes; becomes closed after first write
4. Closing must be propagated forward: shutdown must not occur until the final write completes; becomes closed after first write; preventClose = true

For propagating errors forward, we only have:
1. Errors must be propagated forward: shutdown must not occur until the final write completes
2. Errors must be propagated forward: abort should not happen until all queued writes complete

I suggest we rework these error tests to be more similar to their closing counterparts, so we end up with:
1. Errors must be propagated forward: shutdown must not occur until the final write completes
2. Errors must be propagated forward: shutdown must not occur until the final write completes; preventAbort = true
3. Errors must be propagated forward: shutdown must not occur until the final write completes; becomes errored after first write
4. Errors must be propagated forward: shutdown must not occur until the final write completes; becomes errored after first write; preventAbort = true

Should be simple enough to rename the existing tests and add two more variants. WPT PR coming right up! 😉 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/884#issuecomment-367126039