- From: Domenic Denicola <notifications@github.com>
- Date: Wed, 07 Feb 2018 12:32:03 -0800
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/streams/pull/875/review/94859459@github.com>
domenic commented on this pull request. > + <p>A function that is called after the <a>producer</a> signals, via {{WritableStream/abort()|stream.abort()}} or + {{WritableStreamDefaultWriter/abort()|writer.abort()}}, that they wish to abruptly close the stream and put it in an + errored state, discarding any queued-up writes. It takes as its argument the same value as was passed to those + methods by the producer.</p> + + <p>This function can clean up any held resources, much like {{underlying sink/close()}}, but perhaps with some + custom handling.</p> + + <p>If the shutdown process is asynchronous, the function can return a promise to signal success or failure; the + result will be communicated via the return value of the called <code>abort()</code> method. Throwing an exception is + treated the same as returning a rejected promise. Regardless, the stream will be errored with a new {{TypeError}} + indicating that it was aborted.</p> + </dd> +</dl> + +The <code>controller</code> argument passed to {{underlying sink/start()}} and {{underlying sink/write()}} is an Hmm, I think it's best to leave as-is; I don't feel comfortable talking about the methods before they are defined, and duplicating it is not good. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/875#discussion_r166746134
Received on Wednesday, 7 February 2018 20:32:57 UTC