- From: Matt Giuca <notifications@github.com>
- Date: Sun, 04 Feb 2018 18:29:13 -0800
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 5 February 2018 02:29:37 UTC
As @annevk pointed out recently, you can't perform URL parsing by writing "new URL" (the constructor does not parse strings). You need to explicitly "parse" the URL string. I also found a number of places where URL parsing is unnecessary, because the spec text was attempting to parse something that was already a URL (not a string). This PR fixes these issues. Note that "parse x using y as base" is already standard terminology throughout this document, and "parse" links to the URL Parser in references. You can view, comment on, or merge this pull request online at: https://github.com/w3c/manifest/pull/649 -- Commit Summary -- * Navigation scope: Link to URL concept, not URL spec. * Navigation scope algorithm takes a URL, not a string. * start_url processing: Don't parse document URL. * Explicitly perform URL parsing instead of constructing a new URL. -- File Changes -- M index.html (41) -- Patch Links -- https://github.com/w3c/manifest/pull/649.patch https://github.com/w3c/manifest/pull/649.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/manifest/pull/649
Received on Monday, 5 February 2018 02:29:37 UTC