- From: Marcos Cáceres <notifications@github.com>
- Date: Wed, 19 Dec 2018 20:41:37 -0800
- To: w3c/screen-orientation <screen-orientation@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/screen-orientation/pull/126/review/186843431@github.com>
marcoscaceres commented on this pull request.
Some suggestions for breaking this up a bit.
> @@ -297,11 +297,43 @@ <h2>
For a given <a>document</a>, the <a>current orientation type</a> and
the <a>current orientation angle</a> are strongly linked in the sense
that for any given type, there will be a specific angle associated.
- However, the <a>user agent</a> can associate <code>*-primary</code>
- and <code>*-secondary</code> values at will. For example, if
- <code>90</code> is associated with <code>landscape-primary</code> and
- <code>270</code> with <code>landscape-secondary</code> for one
- <a>document</a> , another one MAY get the opposite relationship.
+ However, the <a>user agent</a> can associate certain
+ <code>*-primary</code> and <code>*-secondary</code> values at will.
```suggestion
<code>*-primary</code> and <code>*-secondary</code> values at will:
```
> @@ -297,11 +297,43 @@ <h2>
For a given <a>document</a>, the <a>current orientation type</a> and
the <a>current orientation angle</a> are strongly linked in the sense
that for any given type, there will be a specific angle associated.
- However, the <a>user agent</a> can associate <code>*-primary</code>
- and <code>*-secondary</code> values at will. For example, if
- <code>90</code> is associated with <code>landscape-primary</code> and
- <code>270</code> with <code>landscape-secondary</code> for one
- <a>document</a> , another one MAY get the opposite relationship.
+ However, the <a>user agent</a> can associate certain
+ <code>*-primary</code> and <code>*-secondary</code> values at will.
+ One primary orientation will always be determined by the natural
+ orientation of the device and this will then determine the secondary
+ value of its related orientation. For example a phone held in its
Breaking this up at the example might be good. This paragraph is getting rather long, and the example is non-normative.
```suggestion
value of its related orientation. </p> <p>For example, a phone held in its
```
> @@ -297,11 +297,43 @@ <h2>
For a given <a>document</a>, the <a>current orientation type</a> and
the <a>current orientation angle</a> are strongly linked in the sense
that for any given type, there will be a specific angle associated.
- However, the <a>user agent</a> can associate <code>*-primary</code>
- and <code>*-secondary</code> values at will. For example, if
- <code>90</code> is associated with <code>landscape-primary</code> and
- <code>270</code> with <code>landscape-secondary</code> for one
- <a>document</a> , another one MAY get the opposite relationship.
+ However, the <a>user agent</a> can associate certain
+ <code>*-primary</code> and <code>*-secondary</code> values at will.
+ One primary orientation will always be determined by the natural
+ orientation of the device and this will then determine the secondary
+ value of its related orientation. For example a phone held in its
+ natural orientation would have a current orientation of
+ <a>portrait-primary</a> and its <a>portrait-secondary</a> orientation
+ would be its position when rotated 180°. The decision on setting the
```suggestion
would be its position when rotated 180°. </p> <p>The decision on setting the
```
> @@ -297,11 +297,43 @@ <h2>
For a given <a>document</a>, the <a>current orientation type</a> and
the <a>current orientation angle</a> are strongly linked in the sense
that for any given type, there will be a specific angle associated.
- However, the <a>user agent</a> can associate <code>*-primary</code>
- and <code>*-secondary</code> values at will. For example, if
- <code>90</code> is associated with <code>landscape-primary</code> and
- <code>270</code> with <code>landscape-secondary</code> for one
- <a>document</a> , another one MAY get the opposite relationship.
+ However, the <a>user agent</a> can associate certain
```suggestion
</p><p>However, the <a>user agent</a> can associate certain
```
> - However, the <a>user agent</a> can associate <code>*-primary</code>
- and <code>*-secondary</code> values at will. For example, if
- <code>90</code> is associated with <code>landscape-primary</code> and
- <code>270</code> with <code>landscape-secondary</code> for one
- <a>document</a> , another one MAY get the opposite relationship.
+ However, the <a>user agent</a> can associate certain
+ <code>*-primary</code> and <code>*-secondary</code> values at will.
+ One primary orientation will always be determined by the natural
+ orientation of the device and this will then determine the secondary
+ value of its related orientation. For example a phone held in its
+ natural orientation would have a current orientation of
+ <a>portrait-primary</a> and its <a>portrait-secondary</a> orientation
+ would be its position when rotated 180°. The decision on setting the
+ other primary and secondary orientation is up to the <a>user
+ agent</a>. For example, it can be based on the device preferred
+ angles, the user's preferred orientations or the current orientation
```suggestion
angles, or the user's preferred orientations, or the current orientation
```
> @@ -297,11 +297,43 @@ <h2>
For a given <a>document</a>, the <a>current orientation type</a> and
the <a>current orientation angle</a> are strongly linked in the sense
that for any given type, there will be a specific angle associated.
- However, the <a>user agent</a> can associate <code>*-primary</code>
- and <code>*-secondary</code> values at will. For example, if
- <code>90</code> is associated with <code>landscape-primary</code> and
- <code>270</code> with <code>landscape-secondary</code> for one
- <a>document</a> , another one MAY get the opposite relationship.
+ However, the <a>user agent</a> can associate certain
+ <code>*-primary</code> and <code>*-secondary</code> values at will.
+ One primary orientation will always be determined by the natural
+ orientation of the device and this will then determine the secondary
+ value of its related orientation. For example a phone held in its
Avoid the word "phone"... maybe just say "device".
> + <a>portrait-primary</a>. When a device is turned 180° from its
+ natural orientation, its orientation will be represented by the
+ secondary value related to its natural orientation, either
+ <a>landscape-secondary</a> or <a>portrait-secondary</a>. The <a>user
+ agent</a> sets the other primary orientation, which will be either
+ <a>landscape-primary</a> at <a>angle</a> <code>90</code> or
+ <code>270</code> or <a>portrait-primary</a> at <a>angle</a>
+ <code>90</code> or <code>270</code>. The secondary orientation is set
+ at <a>angle</a> <code>90</code> or <code>270</code> depending on what
+ was set for the related primary orientation value. In the case of the
+ above phone example, the <a>user agent</a> may determine that the
+ phone’s <a>landscape-primary</a> orientation is at <a>angle</a>
+ <code>270</code> (where the phone is rotated 90° clockwise). In this
+ case its landscape-secondary orientation is <a>angle</a>
+ <code>90</code> (where the phone is rotated 90° counterclockwise).
+ Another document MAY get the opposite relationship.
This MAY here is somewhat confusing, specially because it feels like it's contradicting the next paragraph.
> + angles, the user's preferred orientations or the current orientation
+ when the application starts.
+ </p>
+ <p>
+ When a device is held in its natural orientation, its orientation is
+ represented either by <a>landscape-primary</a> or
+ <a>portrait-primary</a>. When a device is turned 180° from its
+ natural orientation, its orientation will be represented by the
+ secondary value related to its natural orientation, either
+ <a>landscape-secondary</a> or <a>portrait-secondary</a>. The <a>user
+ agent</a> sets the other primary orientation, which will be either
+ <a>landscape-primary</a> at <a>angle</a> <code>90</code> or
+ <code>270</code> or <a>portrait-primary</a> at <a>angle</a>
+ <code>90</code> or <code>270</code>. The secondary orientation is set
+ at <a>angle</a> <code>90</code> or <code>270</code> depending on what
+ was set for the related primary orientation value. In the case of the
```suggestion
was set for the related primary orientation value. </p> <p>In the case of the
```
> + when the application starts.
+ </p>
+ <p>
+ When a device is held in its natural orientation, its orientation is
+ represented either by <a>landscape-primary</a> or
+ <a>portrait-primary</a>. When a device is turned 180° from its
+ natural orientation, its orientation will be represented by the
+ secondary value related to its natural orientation, either
+ <a>landscape-secondary</a> or <a>portrait-secondary</a>. The <a>user
+ agent</a> sets the other primary orientation, which will be either
+ <a>landscape-primary</a> at <a>angle</a> <code>90</code> or
+ <code>270</code> or <a>portrait-primary</a> at <a>angle</a>
+ <code>90</code> or <code>270</code>. The secondary orientation is set
+ at <a>angle</a> <code>90</code> or <code>270</code> depending on what
+ was set for the related primary orientation value. In the case of the
+ above phone example, the <a>user agent</a> may determine that the
When I read "above phone example" is a bit too visual, in the sense that I went looking for an actual figure...
```suggestion
aforementioned example, the <a>user agent</a> might determine that the
```
Although, we should consider adding a figure or table. It's is admittedly hard to figure out what's going to be what.
> + when the application starts.
+ </p>
+ <p>
+ When a device is held in its natural orientation, its orientation is
+ represented either by <a>landscape-primary</a> or
+ <a>portrait-primary</a>. When a device is turned 180° from its
+ natural orientation, its orientation will be represented by the
+ secondary value related to its natural orientation, either
+ <a>landscape-secondary</a> or <a>portrait-secondary</a>. The <a>user
+ agent</a> sets the other primary orientation, which will be either
+ <a>landscape-primary</a> at <a>angle</a> <code>90</code> or
+ <code>270</code> or <a>portrait-primary</a> at <a>angle</a>
+ <code>90</code> or <code>270</code>. The secondary orientation is set
+ at <a>angle</a> <code>90</code> or <code>270</code> depending on what
+ was set for the related primary orientation value. In the case of the
+ above phone example, the <a>user agent</a> may determine that the
As a general rule, avoid the RFC2119 keywords (may, must, should - even in lowercase) in examples - and other non-normative things - including when you write "For example, ...".
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/screen-orientation/pull/126#pullrequestreview-186843431
Received on Thursday, 20 December 2018 04:42:08 UTC