Re: [whatwg/fetch] Change encoding of WebSocket keyValue to forgiving-base64-encoding (#844)

annevk approved this pull request.

Thanks, would you like to add your name to the Acknowledgments section?

There's a potential follow-up fix here, if you want. Namely the return value of this encoding process is a string, so we need to account for that in the example and we'll need to "isomorphic encode" this string before assigning it as header value (as that does require a byte sequence).



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/844#pullrequestreview-183580751