[whatwg/fullscreen] Two WPT tests flawed (#135)

So in trying to fix Chrome's implementation to pass these layout tests

https://github.com/web-platform-tests/wpt/blob/master/fullscreen/api/element-request-fullscreen-two-elements-manual.html
https://github.com/web-platform-tests/wpt/blob/master/fullscreen/api/element-request-fullscreen-two-iframes-manual.html

I've found that they are completely incorrect. While Chrome does suffer from a problem that we do a in order tree traversal in the fullscreen_controller when entering fullscreen, that is fixable. But the problem really stems from the fact that these tests listen for onfullscreenchange event which is to be sent in the event loop. The problem is that how Chrome implements this we end up getting two fullscreenchange events and they examine the document.fullscreenElement which ends up being appended twice and the final array is ['a', 'a'] not the desired ['b', 'a'] of the test.

And I do believe this is okay according to the current spec.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/issues/135