- From: Domenic Denicola <notifications@github.com>
- Date: Fri, 17 Aug 2018 13:29:20 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 17 August 2018 20:29:42 UTC
domenic approved this pull request. LGTM with potential improvement. > @@ -5504,11 +5496,11 @@ constructor must run these steps: <var>origin</var>, set <var>window</var> to <var>request</var>'s <a for=request>window</a>. - <li><p>If <var>init</var>'s <code>window</code> member is present and it is non-null, then - <a>throw</a> a <code>TypeError</code>. + <li><p>If <var>init</var>["<code>window</code>"] <a for=map>exists</a> and is non-null, then If you do `{{RequestInit/window}}` it links, which is nice. Here and elsewhere. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/794#pullrequestreview-147370143
Received on Friday, 17 August 2018 20:29:42 UTC