Re: [whatwg/fetch] Editorial: turn CORS-preflight cache into a list (#744)

jakearchibald requested changes on this pull request.

Couple of minor bugs, but otherwise LGTM

>  script:
-  - curl --remote-name --fail https://resources.whatwg.org/build/deploy.sh && bash ./deploy.sh
+  - make deploy

This seems unrelated to the editorial stuff. Is this mostly a separate change?

> @@ -3190,18 +3190,16 @@ optional <i>CORS flag</i> and <i>CORS-preflight flag</i>, run these steps:
    <li>
     <p>If the <i>CORS-preflight flag</i> is set and one of these conditions is true:
 
-    <ul>
-     <li>There is no <a for=cache>method cache match</a> for
-     <var>request</var>'s <a for=request>method</a> using <var>request</var>,
-     and either <var>request</var>'s <a for=request>method</a> is a not a
-     <a>CORS-safelisted method</a> or <var>request</var>'s
+    <ul class=brief>
+     <li><p>There is no <a for=cache>method cache entry match</a> for <var>request</var>'s

Remove `for=cache`.

>  
- <dt><a for=cache>url</a>
- <dd><var>request</var>'s <a for=request>current url</a>
+  <dl>
+   <dt><a for=cache>serialized origin</a>

In this `<dl>`, `for=cache` should be `for="cache entry"` (or remove the `for` from each item and add `link-for="cache entry"` to the `<dl>`.

>  
- <dt><a for=cache>header name</a>
- <dd><var>headerName</var>
-</dl>
+   <dt><a for=cache>method</a>
+   <dd><p><var>method</var>
+
+   <dt><p><a for=cache>header name</a>

Remove `<p>`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/744#pullrequestreview-146489990