- From: Mattias Buelens <notifications@github.com>
- Date: Wed, 08 Aug 2018 04:41:58 -0700
- To: whatwg/encoding <encoding@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 8 August 2018 11:42:23 UTC
MattiasBuelens approved this pull request. One tiny nitpick left, but looks good to go for me. > @@ -1485,7 +1485,8 @@ byteReadable throws an exception, then return a promise rejected with that exception. <li><p><a>Push</a> a <a lt="get a copy of the buffer source">copy of</a> <var>bufferSource</var> to - <var>dec</var>'s <a for=TextDecoderStream>stream</a>. + <var>dec</var>'s <a for=TextDecoderStream>stream</a>. If this throws an exception, then return a + promise rejected with that exception Tiny nit: missing a period at the end of this sentence. 😛 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/encoding/pull/149#pullrequestreview-144378138
Received on Wednesday, 8 August 2018 11:42:23 UTC