Re: [whatwg/fetch] Be clearer about the underlying source of a constructed ReadableStream. (#781)

jyasskin commented on this pull request.

@ricea I'd appreciate if you'd write the web platform test. I'd probably need to do it in November after coming back from leave.

> @@ -1876,18 +1876,45 @@ with given <var>strategy</var>, <var>pull</var> action and <var>cancel</var> act
 are optional, run these steps:
 
 <ol>
- <li><p>Let <var>init</var> be a new object.
+ <li><p>Let <var>startAlg</var> be an algorithm that returns <code>undefined</code>.

Done.

>  
- <li><p>Set <var>init</var>["cancel"] to a function that runs <var>cancel</var> if
- <var>cancel</var> is given.
+ <dl class=switch>
+ <dt>If <var>pull</var> is given
+ <dd>the result of [=promise-calling=] <var>pull</var>().

There's also https://streams.spec.whatwg.org/#promise-call, but it requires a non-`undefined` object parameter. @domenic, it looks like the underlying https://tc39.github.io/ecma262/#sec-call can take undefined there; would it make sense to allow that in `PromiseCall()`?

>  
- <li><p>Let <var>stream</var> be the result of calling the initial value of {{ReadableStream}} as
- constructor with <var>init</var> and <var>strategy</var> if given.
+ <li><p>Let <var>highWaterMark</var> be:
+ <dl class=switch>

I've done this and added the note.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/781#pullrequestreview-143663370