- From: Adam Rice <notifications@github.com>
- Date: Mon, 06 Aug 2018 14:52:16 +0000 (UTC)
- To: whatwg/encoding <encoding@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 6 August 2018 15:12:12 UTC
@MattiasBuelens Thank you for the review. > We should avoid enqueuing empty strings (in TextDecoderStream) or empty Uint8Arrays (in TextEncoderStream). I'm not completely sure about this. I originally preserved empty chunks on the assumption that users would expect that if they put an empty chunk in they would get an empty chunk out. I implemented this at https://github.com/GoogleChromeLabs/text-encode-transform-prollyfill/compare/never-empty?expand=1. Please take a look at the test changes and see what you think of the changed semantics. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/encoding/pull/149#issuecomment-410735401
Received on Monday, 6 August 2018 15:12:12 UTC