- From: Timothy Gu <notifications@github.com>
- Date: Tue, 31 Jul 2018 18:23:39 -0700
- To: whatwg/url <url@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 1 August 2018 01:24:03 UTC
TimothyGu commented on this pull request. > @@ -19,6 +19,11 @@ In short, change `url.bs` and submit your patch, with a [good commit message](https://github.com/whatwg/meta/blob/master/COMMITTING.md). Consider reading through the [WHATWG FAQ](https://whatwg.org/faq) if you are new here. +If your patch makes normative (behavioural) changes, you will be asked to add or update +[tests](https://github.com/web-platform-tests/wpt), and update the +[jsdom/whatwg-url](https://github.com/jsdom/whatwg-url) implementation (see "Tests and I wouldn't call jsdom/whatwg-url an official implementation, so I'd just say it'd be nice of they could do that but it's not a must. WPTs are a must though. > @@ -19,6 +19,11 @@ In short, change `url.bs` and submit your patch, with a [good commit message](https://github.com/whatwg/meta/blob/master/COMMITTING.md). Consider reading through the [WHATWG FAQ](https://whatwg.org/faq) if you are new here. +If your patch makes normative (behavioural) changes, you will be asked to add or update "behavioral" See https://whatwg.org/style-guide#dictionary. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/url/pull/407#pullrequestreview-142200099
Received on Wednesday, 1 August 2018 01:24:03 UTC