- From: Anne van Kesteren <notifications@github.com>
- Date: Fri, 27 Apr 2018 17:09:04 +0000 (UTC)
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 27 April 2018 17:09:29 UTC
@johnwilander I meant `same` and `same-site`, lowercase (`null` is lowercase too: https://fetch.spec.whatwg.org/#origin-header). I don't have a problem with supporting two values initially, personally. As for referrer, see https://github.com/whatwg/fetch/issues/687#issuecomment-382128393. The leak is fairly limited if you only support same and same-site, but it still seems worth addressing with an eye on the future I think. As for error handling, I think either way you open yourself up to problems later. The advantage of failing closed I think is that it's noticed sooner. And if invalid values due spread (as they seem to do for headers), it'll be hard later to enforce a byte-for-byte comparison as many loads will start failing at that point. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/issues/687#issuecomment-385034243
Received on Friday, 27 April 2018 17:09:29 UTC