Re: [whatwg/fetch] Use Infra's abort when (#702)

jakearchibald approved this pull request.

Comments are nits.

> @@ -1566,7 +1566,7 @@ for each associated <a for="fetch group">fetch record</a> whose
  <li><p>Let <var>connection</var> be null.
 
  <li>
-  <p>Run these steps, but abort if the ongoing fetch is <a for=fetch>terminated</a>:</p>
+  <p>Run these steps, but <a>abort when</a> the ongoing fetch is <a for=fetch>terminated</a>:</p>

Remove closing `</p>`

> @@ -2403,7 +2403,7 @@ the request.
 
 <ol>
  <li>
-  <p>Run these steps, but abort if the ongoing fetch is <a for=fetch>terminated</a>:</p>
+  <p>Run these steps, but <a>abort when</a> the ongoing fetch is <a for=fetch>terminated</a>:</p>

Remove closing `</p>`

> @@ -2555,7 +2555,7 @@ with a <i>CORS flag</i> and <i>recursive flag</i>, run these steps:
  <li><p>Let <var>response</var> be null.
 
  <li>
-  <p>Run these steps, but abort if the ongoing fetch is <a for=fetch>terminated</a>:</p>
+  <p>Run these steps, but <a>abort when</a> the ongoing fetch is <a for=fetch>terminated</a>:</p>

Remove closing `</p>`

> @@ -3768,7 +3773,7 @@ Range Requests</cite>. [[HTTP-RANGE]] However, this is not widely supported by b
 
 
  <li>
-  <p>Run these steps, but abort if the ongoing fetch is <a for=fetch>terminated</a>:</p>
+  <p>Run these steps, but <a>abort when</a> the ongoing fetch is <a for=fetch>terminated</a>:</p>

Remove closing `</p>`

> @@ -3865,7 +3870,7 @@ Range Requests</cite>. [[HTTP-RANGE]] However, this is not widely supported by b
   <p class="note no-backref">This construction operation will not throw an exception.
 
  <li>
-  <p>Run these steps, but abort if the ongoing fetch is <a for=fetch>terminated</a>:</p>
+  <p>Run these steps, but <a>abort when</a> the ongoing fetch is <a for=fetch>terminated</a>:</p>

Remove closing `</p>`

> @@ -3941,7 +3946,7 @@ Range Requests</cite>. [[HTTP-RANGE]] However, this is not widely supported by b
 
   <ol>
    <li>
-    <p>While true, breaking if the ongoing fetch <a for=fetch lt=terminated>terminates</a>:
+    <p>While true, <a>abort when</a> the ongoing fetch <a for=fetch lt=terminated>terminates</a>:

This is the only one I'm unsure of, as it feels like the "abort" clause is inside the while clause, whereas it's really the other way around.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/702#pullrequestreview-115525201