Re: [whatwg/dom] Fixes #625. Define Event.srcElement and Event.returnValue for compat. (#626)

cvrebert requested changes on this pull request.



> @@ -675,6 +680,12 @@ The <dfn attribute for=Event><code>bubbles</code></dfn> and
 <dfn attribute for=Event><code>cancelable</code></dfn> attributes
 must return the values they were initialized to.
 
+<p>The <dfn attribute for=Event><code>returnValue</code></dfn> attribute's getter must return false
+if the <a>canceled flag</a> is set, and true otherwise.

> `if the <a>canceled flag</a> is set`

`if <a>context object</a>'s <a>canceled flag</a> is set`

> @@ -675,6 +680,12 @@ The <dfn attribute for=Event><code>bubbles</code></dfn> and
 <dfn attribute for=Event><code>cancelable</code></dfn> attributes
 must return the values they were initialized to.
 
+<p>The <dfn attribute for=Event><code>returnValue</code></dfn> attribute's getter must return false
+if the <a>canceled flag</a> is set, and true otherwise.
+
+<p>The {{Event/returnValue}} attribute's setter must, if the given value is false, set the <a>canceled flag</a>

set **context object's** canceled flag

> @@ -675,6 +680,12 @@ The <dfn attribute for=Event><code>bubbles</code></dfn> and
 <dfn attribute for=Event><code>cancelable</code></dfn> attributes
 must return the values they were initialized to.
 
+<p>The <dfn attribute for=Event><code>returnValue</code></dfn> attribute's getter must return false
+if the <a>canceled flag</a> is set, and true otherwise.
+
+<p>The {{Event/returnValue}} attribute's setter must, if the given value is false, set the <a>canceled flag</a>
+if the {{Event/cancelable}} attribute value is true and the <a>in passive listener flag</a> is unset.

**context object's** in passive listener flag

> @@ -675,6 +680,12 @@ The <dfn attribute for=Event><code>bubbles</code></dfn> and
 <dfn attribute for=Event><code>cancelable</code></dfn> attributes
 must return the values they were initialized to.
 
+<p>The <dfn attribute for=Event><code>returnValue</code></dfn> attribute's getter must return false
+if the <a>canceled flag</a> is set, and true otherwise.
+
+<p>The {{Event/returnValue}} attribute's setter must, if the given value is false, set the <a>canceled flag</a>
+if the {{Event/cancelable}} attribute value is true and the <a>in passive listener flag</a> is unset.

[...] and do nothing otherwise.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/626#pullrequestreview-109923239

Received on Friday, 6 April 2018 01:14:30 UTC