Re: [whatwg/fetch] Introduce {reload, history, submission}-navigation flags (#685)

wanderview requested changes on this pull request.

Sorry, I tried to leave this comment before, but I think it was stuck in github drafts or something.

> @@ -5141,8 +5166,11 @@ constructor must run these steps:
  <a for=request>redirect mode</a>,
  <a for=request>integrity metadata</a> is
  <var>request</var>'s
- <a for=request>integrity metadata</a>, and
- <a>keepalive flag</a> is <var>request</var>'s <a>keepalive flag</a>.
+ <a for=request>integrity metadata</a>,
+ <a>keepalive flag</a> is <var>request</var>'s <a>keepalive flag</a>,
+ <a>reload-navigation flag</a> is  <var>request</var>'s <a>reload-navigation flag</a>,
+ <a>history-navigation flag</a> is  <var>request</var>'s <a>history-navigation flag</a>, and
+ <a>submission-navigation flag</a> is  <var>request</var>'s <a>submission-navigation flag</a>.

So if a fetch event handler dealing with a navigation reload does:

 `let r2 = new Request(evt.request)`

Then `r2.mode` will be "same-origin", but `r2.isReloadNavigation` will be `true`?

That seems a bit unexpected.  Shouldn't we try to keep `isReloadNavigation` in sync with mode being 'navigate'?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/685#pullrequestreview-107017832