Re: [whatwg/dom] Issue #625. Define Event.srcElement and Event.returnValue for compat. (#626)

cvrebert requested changes on this pull request.



> @@ -446,6 +447,7 @@ interface Event {
 
   readonly attribute boolean bubbles;
   readonly attribute boolean cancelable;
+           attribute boolean returnValue;

Also historical? We have `preventDefault()` and `defaultPrevented` nowadays.

> @@ -675,6 +680,12 @@ The <dfn attribute for=Event><code>bubbles</code></dfn> and
 <dfn attribute for=Event><code>cancelable</code></dfn> attributes
 must return the values they were initialized to.
 
+<p>The <dfn attribute for=Event><code>returnValue</code></dfn> attribute must be initialized to true
+when an <a>event</a> is created. When the attribute is set to false it must set the <a>canceled flag</a>

> When the attribute is set to

Should be phrased as a setter instead?: "The `returnValue` attribute’s setter must [...]"

[See `cancelBubble`](https://dom.spec.whatwg.org/#dom-event-cancelbubble) for an example of the getter/setter boilerplate verbiage.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/626#pullrequestreview-108680906