Re: [whatwg/streams] Add examples of using identity transforms to manipulate streams (#847)

ricea commented on this pull request.



> +  return readableStreamToArray(readable).then(array => assert_array_equals(array, [0, 1, 1, 2], 'array should match'));
+}, 'concanateReadables should concatenate readables');
+
+promise_test(t => {
+  const erroredReadable = new ReadableStream({
+    start(controller) {
+      controller.enqueue(2);
+      controller.error();
+    }
+  });
+  const readable = concatenateReadables([arrayToReadableStream([1]), erroredReadable]);
+  const reader = readable.getReader();
+  return reader.read().then(({ value, done }) => {
+    assert_false(done, 'done should be false');
+    assert_equals(value, 1, 'value should be 1');
+    // Error is not passed through due to WritableStreamAbort algorithm step 4.

Yes. I am also regretting making `writable.abort()` throw when the stream is errored, as it forces us to stick in empty catch blocks.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/847#discussion_r147909539