Re: [whatwg/streams] Add a Random Values Generator Demonstration (#844)

ricea commented on this pull request.



> +            controller.error(error);
+            logStatusText('Error occured in the writable stream');
+            return error;
+        },
+
+        close() {
+            logStatusText('Closing the stream');
+            console.log('Stream closed');
+        }
+    });
+
+    /**
+     * Writes a chunk to the span and appends it to the parent element
+     * @param {*} chunk 
+     */
+    async function writeChunk(chunk) {

This function doesn't need to be async as it performs no asynchronous operations. Also, as it is only called within write(), it might as well just be included in that function.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/844#pullrequestreview-69911177

Received on Tuesday, 17 October 2017 14:53:05 UTC