- From: Domenic Denicola <notifications@github.com>
- Date: Mon, 16 Oct 2017 10:53:33 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 16 October 2017 17:53:55 UTC
Yay, this is awesome!! My own nits: > Returns a new request whose url attribute value is input if input is a string, and input’s url These "url"s should be `{{Request/url}}` so they get to be monospace. Also, in web developer facing documentation, I prefer to say "property" instead of "attribute" (probably "value" is also redundant?). > "Referer" header should use backticks instead of "s since headers are byte sequences. > Returns request’s subresource integrity "subresource integrity metadata"? In general I think even though it takes you into the "main" spec, away from web-developer documentation, cross-linking to concepts (e.g. `<a>credentials mode</a>`) is nice for people who want to follow up and learn more about the specifics. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/617#issuecomment-336970308
Received on Monday, 16 October 2017 17:53:55 UTC