- From: Jungkee Song <notifications@github.com>
- Date: Thu, 12 Oct 2017 22:49:11 -0700
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 13 October 2017 05:49:33 UTC
jungkees commented on this pull request. > 1. If |cacheExists| is true, then: - 1. Delete a <a>Record</a> {\[[key]], \[[value]]} <var ignore>entry</var> from its <a>name to cache map</a> where |cacheName| matches entry.\[[key]]. + 1. [=map/Remove=] the [=name to cache map=][|cacheName|]. 1. Return true. Yes, actually the fulfillment handler steps were very much incorrect. I made them run in the event loop and create a promise there and resolve/reject the promise from the parallel steps. Also, while changing them, I changed the interface of Batch Cache Operations such that it runs synchronously without returning a promise and the call sites invoke it from a promise job. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/ServiceWorker/pull/1190#discussion_r144470198
Received on Friday, 13 October 2017 05:49:33 UTC