- From: Anne van Kesteren <notifications@github.com>
- Date: Thu, 12 Oct 2017 02:15:29 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/dom/pull/518/review/68860158@github.com>
annevk requested changes on this pull request. Thanks a lot for doing this! Spotted a couple mistakes, but looks great otherwise. > @@ -261,7 +261,8 @@ against a <var>set</var>, run these steps: <li><p>Let <var>s</var> be the result of <a>parse a selector</a> <var>selectors</var>. [[!SELECTORS4]] - <li><p>If <var>s</var> is failure, then <a>throw</a> a {{SyntaxError}}. + <li><p>If <var>s</var> is failure, then <a>throw</a> a "{{InvalidCharacterError!!exception}}" This should be SyntaxError. > <li>If <var>namespace</var> is the <a>XMLNS namespace</a> and neither <var>qualifiedName</var> - nor <var>prefix</var> is "<code>xmlns</code>", then <a>throw</a> a {{NamespaceError}}. + nor <var>prefix</var> is "<code>xmlns</code>", then <a>throw</a> a + "{{InvalidStateError!!exception}}" {{DOMException}}. This should be NamespaceError. > <li>If <var>node</var> is a <a>host-including inclusive ancestor</a> of <var>parent</var>, <a>throw</a> a - {{HierarchyRequestError}}. + "{{NamespaceError!!exception}}" {{DOMException}}. HierarchyRequestError > @@ -5328,11 +5332,14 @@ invoked, must run these steps: <tr><td>"<code>uievents</code>" </table> - <li><p>If <var>constructor</var> is null, then <a>throw</a> a {{NotSupportedError}}. + <li> + <p>If <var>constructor</var> is null, then <a>throw</a> a "{{NotSupportedError!!exception}}" + {{DOMException}}. There's no need for a newline before the `<p>` here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/518#pullrequestreview-68860158
Received on Thursday, 12 October 2017 09:15:54 UTC