Re: [heycam/webidl] Add mixins (#433)

domenic approved this pull request.

Nits around section structure, but LGTM, let's merge this! Very excited.

> +</pre>
+
+<pre class="grammar" id="prod-MixinMember">
+    MixinMember :
+        Const
+        RegularOperation
+        Stringifier
+        ReadOnly AttributeRest
+</pre>
+
+<pre class="grammar" id="prod-IncludesStatement">
+    IncludesStatement :
+        identifier "includes" identifier ";"
+</pre>
+
+<h4 id="using-mixins-and-partials">Using Mixins and Partials</h4>

Section titles should be sentence case, not title case.

> +
+    partial interface mixin <mark>SomeMixin</mark> {
+      /* mixin_members... */
+    };
+</pre>
+
+The order that members appear in has significance for property enumeration
+in the <a href="#es-namespaces">ECMAScript binding</a>.
+
+Note that unlike [=interfaces=] or [=dictionaries=], [=interface mixins=] do not create types.
+
+Of the extended attributes defined in this specification,
+only the [{{Exposed}}] and [{{SecureContext}}] extended attributes
+are applicable to [=interface mixins=].
+
+An <dfn>includes statement</dfn> is a definition

I think includes statements could be a subsection, similar to how implements statements are before this change.

> @@ -1128,6 +1164,325 @@ The following extended attributes are applicable to interfaces:
 </div>
 
 
+<h3 id="idl-mixins">Mixins</h3>

Should the ID/title here be "Interface mixins"? Or maybe there should immediately be a h4 for "Interface mixins"? Or we can not worry about it until you do dictionary mixins?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/433#pullrequestreview-68745247