- From: Jake Archibald <notifications@github.com>
- Date: Wed, 11 Oct 2017 15:20:13 +0000 (UTC)
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 11 October 2017 15:20:36 UTC
jakearchibald commented on this pull request.
> 1. If |r|'s [=request/url=]'s [=url/scheme=] is not one of "<code>http</code>" and "<code>https</code>", then:
- 1. [=fetch/Terminate=] all the ongoing <a>fetches</a> initiated by |requests| with reason *fatal*.
+ 1. [=fetch/Terminate=] all the ongoing [=fetches=] initiated by |requests| with reason *fatal*.
1. Break the loop.
Yeah I think it's ok to do that, and an early-exit is clearer if the behaviour is identical.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1190#discussion_r144045579
Received on Wednesday, 11 October 2017 15:20:36 UTC