- From: Jungkee Song <notifications@github.com>
- Date: Wed, 11 Oct 2017 01:50:06 -0700
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 11 October 2017 08:50:28 UTC
jungkees commented on this pull request. > </section> <section algorithm="cache-addAll"> <h4 id="cache-addAll">{{Cache/addAll(requests)}}</h4> <dfn method for="Cache"><code>addAll(|requests|)</code></dfn> method *must* run these steps: - 1. Let |responsePromiseArray| be an empty array. - 1. Let |requestArray| be an empty array. + 1. Let |r| be null. + 1. Let |responsePromises| be an empty [=list=]. + 1. Let |requestList| be an empty [=list=]. 1. For each |request| whose type is {{Request}} in |requests|: I don't think we changed it so for that particular reason. The only apparent reason I recall is to make it return early when requests with a non-GET method come in. I'll inspect how we can improve/simplify this part of the algorithm as a separate work. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/ServiceWorker/pull/1190#discussion_r143947557
Received on Wednesday, 11 October 2017 08:50:28 UTC