Re: [w3c/ServiceWorker] Remove incumbent/fetching record from Cache behavior (#1190)

jungkees commented on this pull request.



>              1. Else:
-                1. Let |entries| be the result of running <a>Query Cache</a> algorithm passing a {{Request}} object associated with |r| and |options| as the arguments.
-                1. For each |entry| of |entries|:
-                    1. Let |response| be null.
-                    1. If the <a>incumbent record</a> |incumbentRecord| of the corresponding <a>fetching record</a> in <a>request to response map</a> is not null, set |response| to a copy of |incumbentRecord|.\[[value]].
-                    1. Else, set |response| to a copy of |entry|[1].
-                    1. Add |response| to |responseArray|.
+                1. Let |requestResponses| be the result of running [=Query Cache=] with |r| and |options|.
+                1. [=list/For each=] |requestResponse| of |requestResponses|:
+                    1. Add a copy of |requestResponse|'s response to |responses|.
+            1. [=Queue a task=], on |promise|'s [=relevant settings object=]'s [=responsible event loop=] using the [=DOM manipulation task source=], to perform the following steps:
+                1. Let |responseArray| be an empty JavaScript array, in |realm|.

Addressed. But I want to make sure if I used "in realm" correctly in this change. I suppose the created frozen array is actually converted to a JavaScript array by Web IDL. If so, designating the realm when creating a frozen array as I did here makes sense?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1190#discussion_r143946544