Re: [whatwg/streams] Use "debug" package for logging (#831)

domenic commented on this pull request.

We should add a note about this in https://github.com/whatwg/streams/tree/master/reference-implementation

> @@ -334,7 +338,7 @@ class TransformStreamDefaultSource {
   }
 
   pull() {
-    // console.log('TransformStreamDefaultSource.pull()');
+    verbose('TransformStreamDefaultSource.pull()');

Can we name this TransformStreamDefaultSource.prototype.pull()?

> @@ -241,7 +245,7 @@ class TransformStreamDefaultSink {
   }
 
   write(chunk) {
-    // console.log('TransformStreamDefaultSink.write()');
+    verbose('TransformStreamDefaultSink.write()');

Please let's not use Class.method() for non-static methods. Use .prototype. as appropriate.

> @@ -88,7 +92,7 @@ function TransformStreamError(stream, e) {
 }
 
 function TransformStreamSetBackpressure(stream, backpressure) {
-  // console.log(`TransformStreamSetBackpressure(${backpressure})`);
+  verbose(`TransformStreamSetBackpressure(${backpressure})`);

Maybe `(stream, ${backpressure})` or `() [backpressure = ${backpressure}]` or similar? Right now the mismatch seems a bit confusing.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/831#pullrequestreview-67770993