[whatwg/streams] Note on ReadableStreamDefaultControllerEnqueue is inaccurate (#824) from Adam Rice on 2017-10-04 (public-webapps-github@w3.org from October 2017)

From: Adam Rice <notifications@github.com>
Date: Wed, 04 Oct 2017 09:33:02 +0000 (UTC)
To: whatwg/streams <streams@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <whatwg/streams/issues/824@github.com>

https://streams.spec.whatwg.org/commit-snapshots/cd10872861aa35c0490f5d4ff46db7593e866a87#readable-stream-default-controller-enqueue

> In this case we allow the controller’s enqueue method to be called and silently do nothing

This hasn't been true since [e601d69](https://github.com/whatwg/streams/commit/e601d69f3ba40e6f4b5506e4bb1fbe3f3eabf393) in Dec 2015. The change was documented in the change description, and discussed in #424, so it was clearly intentional. The note was just never removed.

I prefer the new behaviour for `enqueue()` since I think it might be harmful to continue to run code on the assumption that the chunk has been queued. Plus this behaviour has shipped in browsers so changing it now could break running code. I propose removing the note.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/issues/824

Received on Wednesday, 4 October 2017 09:33:40 UTC