- From: Tobie Langel <notifications@github.com>
- Date: Mon, 02 Oct 2017 09:01:06 +0000 (UTC)
- To: heycam/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 2 October 2017 09:01:34 UTC
tobie approved this pull request.
Wow. Great work! Thanks. :)
A single nit, the rest LGTM once handled.
Mind doing a quick check to see if we don't have open issues this would close?
> @@ -8618,9 +8611,9 @@ appears on an [=interface=]
that is not defined to [=interface/inherit=]
from another, it indicates that the internal \[[Prototype]]
property of its [=interface prototype object=]
-will be the intrinsic object [=%ArrayPrototype%=] rather than
-[=%ObjectPrototype%=]. This allows
-Array methods to be used more easily
+will be the intrinsic object {{%ArrayPrototype%}} rather than
+{{%ObjectPrototype%}}. This allows
+{{Array}} methods to be used more easily
I *thought* we had agreed on not linking ES standard lib objects. I think we should be consistent here. And if we change our mind, link them all up in a separate PR.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/451#pullrequestreview-66397582
Received on Monday, 2 October 2017 09:01:34 UTC