Re: [whatwg/fullscreen] Fire events at elements by default, falling back to documents (#90)

upsuper commented on this pull request.

Looks good to me.

I especially wanted to check whether it would work when we are removing element, and it seems even if an element is being removed, it can still be the fullscreen element of the document until the window gets unfullscreened, which is probably fine, so that the rest steps of unfullscreen document would work as normal.

@annevk do you see any other issue in this change?



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/90#pullrequestreview-40453881